Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: clipsmm - A C++ interface to the CLIPS library Alias: clipsmm https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200700 ------- Additional Comments From kevin@xxxxxxxxx 2006-10-01 16:37 EST ------- OK - Package name OK - Spec file matches base package name. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. See below - Sources match upstream md5sum: fb0b3f0466641e560dd1605afea248fd clipsmm-0.0.6.tar.bz2 463fec8779f8647a0dd9bf4ea7e95769 clipsmm-0.0.6.tar.bz2.1 OK - Package compiles and builds on at least one arch. OK - BuildRequires correct OK - Spec has needed ldconfig in post and postun OK - Package owns all the directories it creates. OK - Package has no duplicate files in %files. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Spec has consistant macro usage. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Headers/static libs in -devel subpackage. OK - .pc files in -devel subpackage. OK - .so files in -devel subpackage. OK - -devel package Requires: %{name} = %{version}-%{release} OK - .la files are removed. OK - Package doesn't own any directories other packages own. OK - No rpmlint output. SHOULD Items: OK - Should include License or ask upstream to include it. OK - Should build in mock. Issues: 1. Upstream sources don't match? Can you doublecheck that? I used: http://easynews.dl.sourceforge.net/sourceforge/clipsmm/clipsmm-0.0.6.tar.bz2 to get the source. 2. You have a # Target: fedora-5 at the top of the spec? Can that be removed? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review