Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542036 --- Comment #2 from David Nalley <david@xxxxxxx> 2009-11-28 13:00:06 EDT --- (In reply to comment #1) > Just a few comments for now: > > - You don't provide a source url, > please add a comment like in > http://fedoraproject.org/wiki/Packaging/SourceURL#Troublesome_URLs Done, I provided additional explanation in addition to the url. > > - More than half of the package are docs/tutorials, how about spliting in a > seperate package? > Ok, its very small anyway, but I'd like to always install as less as > nessessary, just a point of view ;) Done > > - You do a lot with chmod -x and the timestamps while converting to utf-8 are > not > preserved: > > How about: > find -type f | xargs chmod -x > dos2unix tutorial/* > dos2unix install.txt license.txt > # Convert to utf-8 > pushd tutorial > for file in calligra.z 20k_c1.txt; do > iconv -f ISO-8859-1 -t UTF-8 -o $file.new $file && \ > touch -r $file $file.new && \ > mv $file.new $file > done > popd As you can likely tell, I just iterated over the files. Thanks for pointing out the need to clean that up. I think that's done now. SPEC: http://ke4qqq.fedorapeople.org/php-fpdf.spec SRPM: http://ke4qqq.fedorapeople.org/php-fpdf-1.6-2.fc12.src.rpm Thanks for the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review