Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542036 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomspur@xxxxxxxxxxxxxxxxx --- Comment #1 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2009-11-28 09:22:11 EDT --- Just a few comments for now: - You don't provide a source url, please add a comment like in http://fedoraproject.org/wiki/Packaging/SourceURL#Troublesome_URLs - More than half of the package are docs/tutorials, how about spliting in a seperate package? Ok, its very small anyway, but I'd like to always install as less as nessessary, just a point of view ;) - You do a lot with chmod -x and the timestamps while converting to utf-8 are not preserved: How about: find -type f | xargs chmod -x dos2unix tutorial/* dos2unix install.txt license.txt # Convert to utf-8 pushd tutorial for file in calligra.z 20k_c1.txt; do iconv -f ISO-8859-1 -t UTF-8 -o $file.new $file && \ touch -r $file $file.new && \ mv $file.new $file done popd ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review