Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225789 Kamil Dudka <kdudka@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(kdudka@xxxxxxxxxx | |) | --- Comment #6 from Kamil Dudka <kdudka@xxxxxxxxxx> 2009-11-25 12:40:42 EDT --- (In reply to comment #5) Thanks for review! I've just committed the proposed changes to CVS, excluding the BuildRoot related one. (+ fixed spelling error with the latest rpmlint filesystem --> file system) > * ExclusiveOS: I don't see a reason to state this explicitly. The > fact that it's a Fedora package guarantees that it will only ever be > compiled for Linux machines. Good idea. 'cvs annotate' says the line has been there since the initial import. > * BuildRoot tag is ignored in Fedora 10+. Consider removing it. However removing it triggers a warning with the latest rpmlint: $ rpmlint --version rpmlint version 0.92 Copyright (C) 1999-2007 Frederic Lepied, Mandriva $ rpmlint genromfs.spec genromfs.spec: W: no-buildroot-tag 0 packages and 1 specfiles checked; 0 errors, 1 warnings. > * Package COPYING, and consider also packaging NEWS (via %doc) Fixed. > * %files section should include %defattr(-,root,root,-) (Notice the > last dash.) Fixed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review