Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225789 Petr Machata <pmachata@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag| |needinfo?(kdudka@xxxxxxxxxx | |) --- Comment #5 from Petr Machata <pmachata@xxxxxxxxxx> 2009-11-25 12:08:44 EDT --- The package is OK overall, I found just a couple nits: * rpmlint report: $ rpmlint x86_64/genromfs-0.5.2-4.fc13.x86_64.rpm \ genromfs-0.5.2-4.fc13.src.rpm genromfs.spec 2 packages and 1 specfiles checked; 0 errors, 0 warnings. * ExclusiveOS: I don't see a reason to state this explicitly. The fact that it's a Fedora package guarantees that it will only ever be compiled for Linux machines. * BuildRoot tag is ignored in Fedora 10+. Consider removing it. * Package COPYING, and consider also packaging NEWS (via %doc) * %files section should include %defattr(-,root,root,-) (Notice the last dash.) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review