Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=539983 --- Comment #2 from Eli Wapniarski <eli@xxxxxxxxxxxxxxxxxxxx> 2009-11-22 02:19:00 EDT --- OK... Its gonna be obvious now that I'm no developer. I've managed to address some of the issues as detailed below. - Split off development libraries to its own package - Modified licensing in spec file to reflect GPL2 code though docs state that qjson licensed under LPGL - Uncommeted and corrected sed line in this spec file I'm open to any suggestions and comments you may have regarding the following issues: - I have no idea how to run the tests. - How do I compile the doxygen doc? Can that be done during rpmbuild? - Since this is a development package, it would probably be best if this was a multilib package. How do I accomplish that? - I thought the %defattr macro conferred ownership to files and directories being installed. Please correct me. - Where can I find an example to properly add FindQJSON.cmake as a requirment? Or better yet and quicker if you could detail the correct line. Looking very forward to your feedback and thankyou very much for your help Spec URL: http://orbsky.homelinux.org/packages/qjson.spec SRPM URL: http://orbsky.homelinux.org/packages/qjson-0.6.3-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review