Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=539983 Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag| |fedora-review? --- Comment #1 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> 2009-11-21 16:16:52 EDT --- Here is my review: ! All relevant doc files should be packaged. - I don't think we need the INSTALL file in %doc - There is doxygen documentation in the doc directory that can be built and packaged. * rpmlint says: qjson.x86_64: W: name-repeated-in-summary QJson qjson.x86_64: W: invalid-license LGPL qjson.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libqjson.so qjson.x86_64: W: devel-file-in-non-devel-package /usr/include/qjson/serializer.h qjson.x86_64: W: devel-file-in-non-devel-package /usr/include/qjson/parser.h qjson.x86_64: W: devel-file-in-non-devel-package /usr/include/qjson/qjson_export.h qjson.x86_64: W: devel-file-in-non-devel-package /usr/include/qjson/serializerrunnable.h qjson.x86_64: W: devel-file-in-non-devel-package /usr/lib64/pkgconfig/QJson.pc qjson.x86_64: E: library-without-ldconfig-postin /usr/lib64/libqjson.so.0.6.3 qjson.x86_64: E: library-without-ldconfig-postun /usr/lib64/libqjson.so.0.6.3 qjson.x86_64: W: devel-file-in-non-devel-package /usr/include/qjson/parserrunnable.h qjson-debuginfo.x86_64: W: invalid-license LGPL qjson.src: W: name-repeated-in-summary QJson qjson.src: W: invalid-license LGPL -The header files, .pc file and the *.so file should go to the devel package. Also the doxygen doc, if built, should go to the devel package. The devel package must require pkgconfig in addition to %{name} = %{version}-%{release} -Summary can simply be "qt-based library that maps JSON data to QVariant objects" -There is GPLv2+ code in the src/ directory, making the effective license GPLv2+. Please verify this, possibly via upstream, as they claim that the library is LGPL. ! The tests in the tests/ directory can be run in %check ! If you can, please make the description more descriptive. Not just a copy of the summary. * Every binary RPM package which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. ? Do we need to keep those commented out lines in the specfile? * %{_includedir}/qjson/ is not owned. * What package owns the directory? %{_datadir}/apps/cmake/modules/ That package needs to be in Requires. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review