Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=537727 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jussi.lehtola@xxxxxx --- Comment #2 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-11-16 08:49:30 EDT --- Just a few notes: - the name of the patch should be something of the lines of slack-0.15.2-fileplacement.patch The most important thing is that it begins with slack- so that if one builds the RPM with rpmbuild the source files of different packages are easily separated. - You shouldn't need to define %defattr for the normal files, just use %defattr(-,root,root,-) For the privileged items you can use the special permissions, although I'd change %defattr(0755,root,root,0700) to %defattr(0700,root,root,0700) to keep things logical.. - I'm wondering whether the use of slack_libdir="%{buildroot}/%{_datadir}/%{name}/lib" is reasonable. Wouldn't slack_libdir="%{buildroot}/%{_libdir}/%{name}" be more logical? Or, in the case of architecture independent files just slack_libdir="%{buildroot}/%{_datadir}/%{name}" Also, please note that currently you don't own the directory %{_datadir}/%{name} that is created by the rpm. - I wouldn't use compression suffixes in the man files, since they can change in the future, so change e.g. %{_mandir}/man1/slack-diff.1.gz to %{_mandir}/man1/slack-diff.1.* -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review