Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=528108 --- Comment #6 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-11-15 13:33:17 EDT --- For -2: ! BuildRequires - It is up to you, however usually all BuildRequires are written in the main package section. * Parallel make - Still parallel make is missing in two places (if possible, please enable it) --------------------------------------------------------- 90 sed -i 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g' libtool 91 sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool 92 make 116 sed -i 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g' libtool 117 sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool 118 make --------------------------------------------------------- * Timestamp - Please consider to use: --------------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" --------------------------------------------------------- to keep timestamps on installed files. This method usually works for Makefiles generated by recent autotools. * Directory ownership issue - Some directories are not owned by any packages, ref: https://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Ownership https://fedoraproject.org/wiki/Packaging:UnownedDirectories#Common_Mistakes On i686: ---------------------------------------------------------- /usr/lib/vuurmuur/plugins/ /usr/share/vuurmuur/ /usr/share/vuurmuur/config/ ---------------------------------------------------------- ! Note At least with rpm >= 4.7, $ rpm -ivv *.rpm will show such information like ---------------------------------------------------------- D: Vuurmuur-0.7-2.fc12.i686: Header SHA1 digest: OK (84243c0b26f8e16c6b9f0bd2d14909735bf4f266) D: install: Vuurmuur-0.7-2.fc12 has 10 files, test = 0 D: opening db index /var/lib/rpm/Triggername create mode=0x42 Vuurmuur-0.7-2.fc12 D: ========== Directories not explicitly included in package: D: 0 /usr/lib/ D: 1 /usr/lib/vuurmuur/plugins/ D: 2 /usr/share/doc/ D: ========== D: /usr/lib/vuurmuur directory created with perms 0755, no context. D: /usr/lib/vuurmuur/plugins directory created with perms 0755, no context. D: fini 120777 1 ( 0, 0) 20 /usr/lib/libvuurmuur.so.0;4b003ba3 D: fini 100755 1 ( 0, 0) 255652 /usr/lib/libvuurmuur.so.0.6.0;4b003ba3 ---------------------------------------------------------- See the lines which shows "directory created with perms 0755, no context." * Service ----------------------------------------------------------- [root@localhost ~]# service vuurmuur status vuurmuur は停止しています vuurmuur_log は停止しています [root@localhost ~]# service vuurmuur start Starting vuurmuur:Error (-1): could not open configfile '/etc/vuurmuur/config.conf': No such file or directory (in: init_config). Initializing config failed. [失敗] ----------------------------------------------------------- ( Well, "は停止しています" is "is stopped", "失敗" is "FAILED", currently due to the bug in initscripts (bug 537682) I cannot change these messages into English... ) - I think it is preferable to install the default /etc/vuurmuur/config.conf file (Fedora prefers that the package works as it is by default) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review