Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533725 --- Comment #2 from Jeroen van Meeuwen <kanarip@xxxxxxxxxxx> 2009-11-14 20:21:03 EDT --- (In reply to comment #1) > Some notes: > > * We now prefer to use %global rather than %define. > Fixed. > * Defined %ruby_sitelib macro is not used and seems unneeded. > Fixed. > * License tag should be GPLv2 > Fixed. > * Make build.log more verbose (gem -V should do this), so that > we can check if Fedora specific compilation flags are correctly > honored. > Fixed, and it does. > * Please don't strip binaries by yourself and create debuginfo > rpm correctly. > Fixed. > * Enable %check, because this gem contains test/ directory > Fixed. > * Mark %geminstdir/AUTHORS or so as %doc properly. > Fixed this file, and other files as well. > * This package should not own the directory %{ruby_sitearch}/ > itself. > Fixed. > * I don't think %{geminstdir}/lib can be removed. > Fixed. > * Please use defined macro (especially %geminstdir) also > in other place (like in %files) Fixed. New SPEC: http://www.kanarip.com/custom/SPECS/rubygem-linecache.spec New SRPM: http://www.kanarip.com/custom/f12/SRPMS/rubygem-linecache-0.43-2.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review