Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533725 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #1 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-11-09 11:12:17 EDT --- Some notes: * We now prefer to use %global rather than %define. * Defined %ruby_sitelib macro is not used and seems unneeded. * License tag should be GPLv2 * Make build.log more verbose (gem -V should do this), so that we can check if Fedora specific compilation flags are correctly honored. * Please don't strip binaries by yourself and create debuginfo rpm correctly. * Enable %check, because this gem contains test/ directory * Mark %geminstdir/AUTHORS or so as %doc properly. * This package should not own the directory %{ruby_sitearch}/ itself. * I don't think %{geminstdir}/lib can be removed. * Please use defined macro (especially %geminstdir) also in other place (like in %files) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review