Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533744 --- Comment #2 from Fabien Georget <fabien.georget@xxxxxxxxx> 2009-11-10 10:12:03 EDT --- Spec URL: http://www.bde.espci.fr/~george27/ImageJ.spec SRPM URL: http://www.bde.espci.fr/~george27/ImageJ-1.43-0.2.j.fc12.src.rpm Thanks for these comments 1) I agree, I wasn't very happy with "Amusement/Graphics". (This is not a funny tool ^^) But I didn't know the best group. Your choice seems correct. 2) This source is only for the launch script and some macros not included in the source package but quite useful. I don't use anything else (not the jre nor the .jar file) in the final package. But yes, I don't think about this, maybe include them in the src.rpm is against fedora guidelines I will try to get them from an other way. 3) Yes I forgot to change the description for the one above. But your description looks better (more concise) 4) I added some comments 5) Changed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review