[Bug 533744] Review Request: ImageJ - Image Processing and Analysis in Java

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=533744


D Haley <mycae@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mycae@xxxxxxxxx




--- Comment #1 from D Haley <mycae@xxxxxxxxx>  2009-11-10 07:02:36 EDT ---
Quick comments:

*Group is not really that great. I would recommend Applications/Engineering
over Amusements/Graphics, but I am open to debate. Neither fit, but amusements
is more for games and "toy" applications. ImageJ is targeted towards scientific
applciations

*Why do you include a build for x86-64 as Source2? It would be better to
provide a repack script if you only need a few files. remember that
ij142-linux64 includes its own vm -- which is really unneccesary as it is
massive and we already have one. It might possibly even be against fedora
guidelines, depending on what gets bundled in the VM (not all of the sun code
is free), don't quote me on that though.

*Description is a bit short, the one you have included above is better. Or
maybe something like below or something else. Just try to distinguish it from
say, gimp or inkscape, which are targeted towards artistic, rather than
scientific analysis:

ImageJ is a public domain Java image processing program. It can display,        
edit, analyze a wide variety of image data, including image sequences. Imagej   
can be used for quantitative analysis of engineering and scientific image data.

*Patch names are not descriptive. Please include a comment above the patches to
say what they do. You may wish to send the script patch upstream. If you do,
please make a note in the spec.

*Version tag is a bit wrong, as it does not say which exactly upstream version
of ImageJ you are using (a, b,c,d, ...) . You may need to follow the guidelines
at
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Non-Numeric_Version_in_Release

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]