Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529496 --- Comment #9 from Felipe Contreras <felipe.contreras@xxxxxxxxx> 2009-11-08 11:26:06 EDT --- (In reply to comment #7) > With "confirm the licensing in the source files" I actually refer to the > Appendix of the GPL and LGPL. Worth reading. That text says "It is safest" to do that, but there's no actual *requirement*. You can find many source files in the linux kernel that don't have such notices. > > I didn't get those warnings > > Try again. They are printed with default %optflags on Fedora 11. Plain > rpmbuild. Not even mock is necessary. Right. I saved the output and now I can see it. It's a bit difficult to spot them with so much noise. But anyway, those are fixed now. > > rpmlint > > > Warnings not always need to be fixed. > > The ReviewGuidelines (which are not specific to package reviewers, because > packagers ought to review their own packages, too), say: > > | MUST: rpmlint must be run on every package. The output should > | be posted in the review.[1] > > The second part of that rule is just a "should", but if you are in search of a > sponsor, you ought to follow such recommendations and do this homework. At the > same time you could explain why you don't fix things rpmlint reports. I followed the "Package Review Process" and I don't see this in any of the steps for my role of "Contributor". I see it on the list of things for the reviewer, but the reference points to: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint If you want people to post rpmlint output on the first run, then the review process document must be updated. > > Strange, I don't have that in my .spec file. Maybe I send an outdated one. > > I explicitly referred to the pkgconfig file, NOT the .spec file. Take your time > when reading reviews, don't rush. Ok. I don't seem to find any documentation that says which dependencies I should put there, and which not. Anyway, I guess it makes sense to remove it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review