Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=532874 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomspur@xxxxxxxxxxxxxxxxx --- Comment #2 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2009-11-06 10:28:39 EDT --- Just a few comments about the spec: - rpmlint: xorg-x11-drv-wacom.src: E: invalid-spec-name xorg-x11-drv-wacom.src: W: mixed-use-of-spaces-and-tabs (spaces: line 6, tab: line 54) 1 packages and 0 specfiles checked; 1 errors, 1 warnings. The spec should be xorg-x11-drv-wacom.spec… - In the devel package is a *.pc file, so at least the devel package should require pkg-config - %global over %define, see: https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define - Does the devel package really need to own %{_includedir}/xorg? I'd say, that you should require xorg-x11-server-devel to get this folder and don't own this dir. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review