Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mesa-libGLw - Xt / Motif OpenGL widgets https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188974 ------- Additional Comments From pertusus@xxxxxxx 2006-09-28 07:14 EST ------- * The %build and %install section are broken. Indeed make don't seem to care about environment variables, and besides there aren't set to meaningfull values, especially in the build section. I'll attach a patch that simplifies %build and %install a lot. It should be tested on a x86_64, I only verified that it is right on x86, although LIB_DIR=%{_lib} is there to have things right. * pkgconfig don't seems to be used in the glw build, I think this BR should be dropped. * lesstif-devel allready requires libXt-devel * is it true that -devel don't requires lesstif-devel? * When linking, the -L are not needed because we link only against libs in default linker directories. no need to remove the dirs from PROGRAM_DIRS they don't exist anyway. The only one which could be removed is util, but it isn't there. I'll attach a modified mesa-6.5.1-libGLw.patch which implements that. * rpmlint has relevant warnings, but they are suppressed by the change in %build -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review