Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=515752 --- Comment #13 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-11-02 10:40:38 EDT --- Some notes: - "Requires: python" is not needed as rpmbuild automatically adds "Requires: python(abi) = 2.6" to the rebuilt binary rpm. - Adding "%dir %{python_sitelib}/soaplib" is not needed because %files entry "%{python_sitelib}/*" already contains this. Note that ------------------------------------------------------ %files foo/ ------------------------------------------------------ (while foo is a directory) contains the directory foo/ itself and all files/directories/etc under foo/ - I usually recomment to include revision number in the rpm release tag. Other notes: - Now Fedora recommends to use %global instead of %define: https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define - python egg file must not be excluded, and it must be created during build process https://fedoraproject.org/wiki/Packaging/Python#setuptools.2Feggs - For creating tarball from svn, it is also recommended to include revision number in the tarball name. - It is recommended that you put one line between each %changelog entry like: ------------------------------------------------------- * Wed Feb 4 2009 Jordan O'Mara <jsomara@xxxxxxxxx> - 0.7.2-2.20080816svn39 - Added patch for manually setting wsdl url * Tue Sep 16 2008 Jordan O'Mara <jsomara@xxxxxxxxx> - 0.7.2-1.20080816svn39 - Initial packaging for Fedora. ------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review