Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=515752 --- Comment #12 from LINBIT <partner@xxxxxxxxxx> 2009-11-02 01:02:29 EDT --- So here is my summary of list of items I would suggest to change. - Add "python" to Requires. - Add comment to spec explaining how to create a tar ball from SVN, as suggested in http://www.fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control - Add %dir %{python_sitelib}/soaplib to %files section as suggested in http://fedoraproject.org/wiki/Packaging:Python#System_Architecture - Add an %exclude in %files for %{python_sitelib}/tests - Drop SVN rev from Release (optional) Other than that, the package looks fine to me. I suppose the build dependency on python-devel, while superfluous, should probably stay in so as not to confuse others and maintain compliance with http://fedoraproject.org/wiki/Packaging:Python. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review