Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=532315 --- Comment #2 from Michal Ingeli <mi@xxxxx> 2009-11-02 06:23:18 EDT --- (In reply to comment #1) > 1.) Please remove jpackage artifacts: > > section macro: > %define section free done > javadoc symlink (you even create it twice for some reason!?): > ln -s %{name}-%{version} $RPM_BUILD_ROOT%{_javadocdir}/%{name} # ghost symlink another forgotten fragment of original package > 2.) You can probably rely on default file modes: > > -%defattr(0644,root,root,0755) > +%defattr(-,root,root,-) > > > 3.) Please do not include TeX sources in documentation. PDFs ale probably > enough. done. some files had +x in documentation sources, but as they are not included now in -manual subpacakges, I can rely on defaults. > 4.) Please consider renaming nanoxml-manual-lite to nanoxml-lite-manual, which > may be more consistent. If you need to retain compatibility and upgrade path > from jpackage, use Provides tag and Obsoletes tag for older version to > properly replace it. Renamed. I also added obsoletes and provides with version ranges. Hope I did it right way. Spec URL: http://v3.sk/~xyzz/rpm/intellij-idea/nanoxml.spec SRPM URL: http://v3.sk/~xyzz/rpm/intellij-idea/nanoxml-2.2.3-5.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review