Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=532315 --- Comment #1 from Lubomir Rintel <lkundrak@xxxxx> 2009-11-01 10:07:57 EDT --- 1.) Please remove jpackage artifacts: section macro: %define section free javadoc symlink (you even create it twice for some reason!?): ln -s %{name}-%{version} $RPM_BUILD_ROOT%{_javadocdir}/%{name} # ghost symlink 2.) You can probably rely on default file modes: -%defattr(0644,root,root,0755) +%defattr(-,root,root,-) 3.) Please do not include TeX sources in documentation. PDFs ale probably enough. 4.) Please consider renaming nanoxml-manual-lite to nanoxml-lite-manual, which may be more consistent. If you need to retain compatibility and upgrade path from jpackage, use Provides tag and Obsoletes tag for older version to properly replace it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review