Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531391 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-10-30 13:59:23 EDT --- Well, * debug_package - "%define debug_package %{nil}" is not needed for noarch srpm. ! sed line for desktop - I suggest to move "sed -i" line to %prep as * Modifying text file by sed like this is like applying patches, which is usually done at %prep * And moving to %prep prevents this line from being called with "$ rpmbuild -bc --short-circuit" * Desktop file - Categories "Application" "X-Fedora" are deprecated and should be removed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review