Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=528010 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #5 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2009-10-30 13:40:26 EDT --- (In reply to comment #4) > (In reply to comment #3) > > Issues: > > - no desktop file (MUST) > > Added. Ok, there is no icon present, you could install PyMca4.3.0/PyMca/PyMcaSplashImage.png into pixmaps and use that... > > > - keeping timestamps are not everywhere (no must) > What are you referring to..? e.g. # Get rid of buildroot in files in %{_bindir} for bin in %{buildroot}%{_bindir}/*; do sed -i 's|%{buildroot}||g' $bin done The same as the other loop, where you preserve them now. > > > - BR: python-devel (MUST) > > Yes, this is needed now since it isn't pulled in anymore by > python-setuptools-devel. Ok, on my system I have only installed python-devel and python-setuptools… -devel is not needed, that's why I complained about this ;) ____________________________ Only minor fixes can be done: installing an icon and the timestamps. || VV ____________________________ APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review