Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530205 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #6 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2009-10-23 19:16:59 EDT --- (In reply to comment #5) > MSVC Express is a free download. :p I still don't recommend using it if you > can avoid it either way, though. Horrifically crappy development environment > compared to vim. ;) Yes, another vim lover ;) > > I emailed upstream about the license discrepancy. In my totally non-legal > opinion I don't see a problem with the slight difference in wording... but if > upstream is non-responsive, what should I do to get this looked at and approved > by the appropriate parties? > I don't believe this is a problem, just wanted to point to the difference. When they say nothing, it's the same as not requires. If they would like to require it, they should say it… > 1) I'll replace with %global. OK > > 2) There are comments above the patches in the spec file... I thought that's > what the policy meant. Further expanded that patches have been mamiled. That they have been mailed should be the what the policy meant. OK > 3) My belief is that no extra Requires should be added at all. The examples > are just example code, not part of anything you actually have to compile to use > AntTweakBar. Further, the AntTweakBar.h header and API are explicitly designed > to work independently of any mainloop. The SDL, GLUT, and GLFW examples are > just examples of how to integrate with those mainloops, but the user can > integrate with Allegro or GTK or Qt or anything else they want to use (so long > as it provides an OpenGL context). You can easily write and compile code that > links against AntTweakBar and some other toolkit that uses OpenGL internally > without ever using any OpenGL header though, so even a requirement on OpenGL is > not required to use AntTweakBar. It's fine the way it is, IMO. I found this argumentation in a bug elsewhere too. Even if it's sourcecode, it's just considered as documentation so the user sees from compiler errors (or needs to know) what to link. One last thing todo: Instead changelog: * Wed Oct 23 2009 Sean Middleditch <sean@xxxxxxxxxxxxxx> 1.13-4 - Use %global instead of %define write * Wed Oct 23 2009 Sean Middleditch <sean@xxxxxxxxxxxxxx> 1.13-4 - Use %%global instead of %%define - Note that patches have been sent to upstream. This way the macros are not expanded in the changelog (what you want here ;)) Do that and it's _________________________ APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review