Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: supertuxkart - Kids 3D go-kart racing game featuring Tux https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207927 ------- Additional Comments From j.w.r.degoede@xxxxxx 2006-09-26 06:29 EST ------- (In reply to comment #2) > OK - Spec is legible. > No, but ok Erm, how is it not legible? Any comments / suggestions to improve its legibleness are very much welcome. > Issues: > > 1. Perhaps 'images-leagal.txt' could be renamed 'supertuxkart-images-legal.txt' > just to make it easier to find if you unpack the src.rpm? (just a minor nit). Done > Has any move been made to get upstream to change images to make it more > distributable moving forward? > Yes now that there is an upstream once more I've contacted them about this and they are looking into this. > 2. Your provides and obsoletes don't look quite right to me. > Perhaps that should be: > > Provides: tuxkart = %{version}-%{release} > Obsoletes: tuxkart <= 0.4.0-6 > That won't work because then the Provides would be older then the Obsoletes making the package self obsoleting > 3. rpmlint says: > supertuxkart incoherent-version-in-changelog 0.4.0-5 0.2-1.fc6 > (the .fc6 doesn't need to be there, just the version... ) > AH my bad, I didn't update the changelog, fixed. Here is a new version with all this fixed: Spec URL: http://people.atrpms.net/~hdegoede/supertuxkart.spec SRPM URL: http://people.atrpms.net/~hdegoede/supertuxkart-0.2-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review