Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: supertuxkart - Kids 3D go-kart racing game featuring Tux https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207927 ------- Additional Comments From kevin@xxxxxxxxx 2006-09-25 20:39 EST ------- OK - Package name OK - Spec file matches base package name. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. No, but ok - Sources match upstream md5sum: (images removed) OK - Package compiles and builds on at least one arch. OK - BuildRequires correct OK - Package owns all the directories it creates. OK - Package has no duplicate files in %files. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Spec has consistant macro usage. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package is a GUI app and has a .desktop file OK - Package doesn't own any directories other packages own. See below - No rpmlint output. SHOULD Items: OK - Should include License or ask upstream to include it. OK - Should build in mock. Issues: 1. Perhaps 'images-leagal.txt' could be renamed 'supertuxkart-images-legal.txt' just to make it easier to find if you unpack the src.rpm? (just a minor nit). Has any move been made to get upstream to change images to make it more distributable moving forward? 2. Your provides and obsoletes don't look quite right to me. Perhaps that should be: Provides: tuxkart = %{version}-%{release} Obsoletes: tuxkart <= 0.4.0-6 I'm looking at: http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head- 581c3fb3ff1c6ef7404e8b288b59cd5280d75ad6 3. rpmlint says: supertuxkart incoherent-version-in-changelog 0.4.0-5 0.2-1.fc6 (the .fc6 doesn't need to be there, just the version... ) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review