Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=528892 Stefan Riemens <fgfs.stefan@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fgfs.stefan@xxxxxxxxx --- Comment #12 from Stefan Riemens <fgfs.stefan@xxxxxxxxx> 2009-10-16 16:22:59 EDT --- Let's go for an informal review (I'm not sponsored yet): + OK ! needs attention + rpmlint is quiet + Package is named according to Fedora MinGW packaging guidelines + Specfile name matches the package base name + Package follows the Fedora MinGW packaging guidelines + The stated license (MIT) is a Fedora approved license + The stated license is the same as the one for the corresponding Fedora package + The package contains the license file (COPYING) + Spec file is written in American English + Spec file is legible + Upstream sources match sources in the srpm b1a8107f99b5d953e8418a5409462294 freeglut-2.6.0-rc1.tar.gz b1a8107f99b5d953e8418a5409462294 freeglut-2.6.0-rc1.tar.gz + Package builds in mock (Fedora Rawhide i386) koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=1750642 n/a ExcludeArch bugs filed + BuildRequires look sane n/a The spec file MUST handle locales properly n/a binary RPM with shared library files must call ldconfig in %post and %postun + Does not use Prefix: /usr + Package owns all directories it creates + No duplicate files in %files + %files has %defattr + %clean contains rm -rf $RPM_BUILD_ROOT + Consistent use of macros + Package must contain code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect package n/a Header files should be in -devel Fedora MinGW guidelines allow headers in main package n/a Static libraries should be in -static n/a Packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' n/a Library files that end in .so must go in a -devel package n/a -devel must require the fully versioned base + Packages should not contain libtool .la files (though mingw guidelines allow them to be present) n/a Packages containing GUI apps must include %{name}.desktop file + Packages must not own files or directories owned by other packages + %install begins with rm -rf $RPM_BUILD_ROOT + Filenames must be valid UTF-8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review