Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=527488 --- Comment #48 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-10-16 13:42:46 EDT --- Well, * %description - I don't think writing the authors of this software in %description is needed. - And the description "Please report bugs to drbd-dev@xxxxxxxxxxxxxxxx" is in my opinion wrong (because we have our BTS) * BuildRequires - BR: gcc is redundant: https://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 * Dependency between subpackages - Usually the dependency between packages rebuilt from a srpm should be strict EVR (not just version) specific (i.e. usually the dependency should be like: Requires: %{name}-utils = %{version}-%{release} ) https://fedoraproject.org/wiki/Packaging/Guidelines#Requiring_Base_Package * Parallel make - Use %{?_smp_mflags} instead of %{_smp_mflags} because %{_smp_mflags} macro may not be defined. * %bcond_without - If you want to really use %bcond_without/%bcond_with, please support all possible patterns carefully, or just drop to use %bcond_ method. ! For example currently passing "--without utils" to your srpm fails because all other subpackages depend on -utils subpackage but with "--without utils" -utils subpackage won't be rebuilt. * %defattr - Now we recommend to use %defattr(-,root,root,-) * About -rgmanager subpackage - Is -rgmanager part really needed? From the description in the spec file currently this subpackage can be rebuilt only for F-10, which is about to be EOL and on F-11/12/13 this cannot be supported. * License tag - scripts/drbd.ocf is under GPLv2 and installed as /usr/lib/ocf/resource.d/linbit/drbd, -pacemaker subpackage should have "GPLv2 and GPLv2+" license tag (or just GPLv2) * sysvinit script treatment - Some Requires(post) or so are missing. - Would you explain why condrestart is not needed at %postun (on upgrade)? https://fedoraproject.org/wiki/Packaging/SysVInitScript#InitscriptScriptlets - Please use %{_initddir} https://fedoraproject.org/wiki/Packaging/SysVInitScript#Initscripts_on_the_filesystem * Duplicate files - You don't have to include COPYING file as %doc other than -utils subpackage because all other packages depends on -utils subpackage. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review