Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=522777 --- Comment #4 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2009-10-15 01:24:22 EDT --- Unfortunately I ran out of time for doing reviews and haven't been able to get back to this one until now. Thanks for being patient. The odd dependencies are now filtered out properly, but the code you introduced into the spec to do that causes another issue: you are now not consistently using macro forms. Personally I don't know why anyone would ever type "%{__rm}" or "%{__make}" when you could just use "rm" or "make", but if for whatever reason you really want to use those pointless macros then you need to use them consistently, which means using "%{__chmod}", "%{__sed}" and "%{__cat}". Honestly, though, the whole spec is so much easier to read without that pointless stuff. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review