Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502614 --- Comment #30 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-10-04 14:33:14 EDT --- Some random notes * Requires - There is no needed that main package (stfl) should have "Requires: pkgconfig". - "Requires: python" is not needed for -python subpackage. python(abi) dependency is automatically added by rpmbuild itself. * About sed/patch - Well, I am one of the person who uses sed command many times in spec files, however as you already created Patch0/1, I think it is better that you create Patch2 instead of using sed (and also see below: at least one more patch is needed) * Fedora specific compilation flags - are not honored correctly (check the arguments passed to gcc in build.log). For example: ------------------------------------------------------------------------- 57 gcc -pthread -I. -Wall -Os -ggdb -D_GNU_SOURCE -fPIC -c -o public.o public.c 58 gcc -pthread -I. -Wall -Os -ggdb -D_GNU_SOURCE -fPIC -c -o base.o base.c 59 gcc -pthread -I. -Wall -Os -ggdb -D_GNU_SOURCE -fPIC -c -o parser.o parser.c 60 gcc -pthread -I. -Wall -Os -ggdb -D_GNU_SOURCE -fPIC -c -o dump.o dump.c 61 gcc -pthread -I. -Wall -Os -ggdb -D_GNU_SOURCE -fPIC -c -o style.o style.c .... ------------------------------------------------------------------------- * pkgconfig file - stfl.pc.in contains: ------------------------------------------------------------------------- 5 libdir=${exec_prefix}/lib ------------------------------------------------------------------------- This is wrong on 64 bits architecure because libdir should be /usr/lib64 there. * Duplicate documents - You don't have to include the same documents in each subpackage when other package which the package depends on (usually the main package) already contains the documents. * %exclude - I prefer to remove unneeded files at %install instead of using %exclude unless unavoided. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review