Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525211 --- Comment #10 from Jan Klepek <jan.klepek@xxxxxx> 2009-10-03 11:02:21 EDT --- (In reply to comment #9) > Some notes: > > * Unneeded macros > - The defined macro ruby_sitelib does not seem to be used anywhere. > > * License > - Please change the license tag to "GPLv3 with exceptions" > > * Virtual (Build)Requires > - For ruby(gem) modules related (Build)Requires, please don't use > rpm names directly but use virtual Provides like perl: > https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides > Fixed, however I never saw this in Ruby packaging guidelines. Is there any draft of new ruby guidelines which will cover this? > * Macros > - Use macros properly. /usr/bin should be %{_bindir}. > > * Duplicate files > - "LICENSE README.txt" are installed twice (one under %geminstdir, > one under %_defaultdocdir/%name-%version) Spec URL: http://hpejakle.fedorapeople.org/packages/rubygem-ditz.spec SRPM URL: http://hpejakle.fedorapeople.org/packages/rubygem-ditz-0.5-3.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review