Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525211 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #9 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-10-01 14:51:33 EDT --- Some notes: * Unneeded macros - The defined macro ruby_sitelib does not seem to be used anywhere. * License - Please change the license tag to "GPLv3 with exceptions" * Virtual (Build)Requires - For ruby(gem) modules related (Build)Requires, please don't use rpm names directly but use virtual Provides like perl: https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides * Macros - Use macros properly. /usr/bin should be %{_bindir}. * Duplicate files - "LICENSE README.txt" are installed twice (one under %geminstdir, one under %_defaultdocdir/%name-%version) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review