Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526055 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #5 from Martin Gieseking <martin.gieseking@xxxxxx> 2009-10-02 08:04:34 EDT --- (In reply to comment #4) > I applied your change requests and will contact upstream asap asking to include > the license for NaturalDocs files, and possibly the two patches i wrote. OK, fine. Maybe you can also ask upstream to add the complete copyright notice to the source files (as mentioned in section "How to Apply These Terms to Your New Programs" of the LGPL license text). Otherwise it's hard to determine that LGPLv2+ is intended. Furthermore, COPYING contains the text of the old outdated GNU *Library* General Public License. Perhaps the author also wants to update it to the GNU *Lesser* General Public License. The license issues are things to be fixed upstream and no blockers here. Apart from them, everything looks fine now. ------------------------ The package is APPROVED. ------------------------ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review