Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226302 Kevin Fenzi <kevin@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE Flag|fedora-review? |fedora-review+ --- Comment #19 from Kevin Fenzi <kevin@xxxxxxxxx> 2009-09-26 16:13:30 EDT --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPLv2) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: f69db402e1869321cac72ffd2f77fa99 pm-utils-1.2.5.tar.gz f69db402e1869321cac72ffd2f77fa99 pm-utils-1.2.5.tar.gz.orig OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - .pc files in -devel subpackage/requires pkgconfig OK - -devel package Requires: %{name} = %{version}-%{release} OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have subpackages require base package with fully versioned depend. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin OK - check for outstanding bugs on package (merge reviews/rename/re-reviews). Issues: 1. rpmlint says: pm-utils.src: W: strange-permission pm-utils-bugreport-info.sh 0775 pm-utils.src: W: strange-permission pm-utils-99hd-apm-restore 0775 I think we can ignore those. pm-utils.x86_64: W: log-files-without-logrotate /var/log/pm-suspend.log Can be ignored per comment in the spec. pm-utils-devel.x86_64: W: no-documentation Can be ignored. 2. Some non blocking suggestions: Might add a '-p' to your install lines to preserve timestamps of the sources? Currently it's pointless to add smp_mflags, but if there are ever more source files to compile it might be worth considering. I see no blockers at all, so this package is APPROVED. Sorry for the long delay here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review