Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=521909 --- Comment #10 from Michael Schwendt <mschwendt@xxxxxxxxx> 2009-09-25 06:00:24 EDT --- > No, build package will be filed later in %files section > when file not found in %{_lib} will be raised. Calm down. I had pointed that out already and confirmed that the "sed" usage is okay in this case. > BUT, you are free ot do not install ne7ssh-example - > it is not required by anything other. Is that the only benefit you could think of? To save 25KB of example files you introduce a separate package (and corresponding repository metadata)? A separate package which developers, who may have interest in those files, would need to search for. It would be much more plausible to include those files in the -devel package. Examples in source code form are Documentation. > BuildRequires: cmake botan-devel present in spec. You didn't understand or you didn't pay attention to what I wrote. "Requires: botan-devel" is missing in ne7ssh-devel > > It's covered by the guidelines even. > Please, can you point me where? https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation > Should I repeat Summary in %description?? I believe not. You should start with a sentence that explains what the package contains and what "It" refers to. Is it an application? A library? What is it? Instead, the current description starts with "It utilizes Botan library for...". Moving the third paragraph at the beginning of the description and making it start with "This SSH library..." would make *a lot* of sense. Give it a second thought, please. I'm not making up things just for fun. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review