Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=521909 --- Comment #9 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan@xxxxxxxxxxxxx> 2009-09-25 05:06:00 EDT --- (In reply to comment #8) > Only those "sed" transformations, which would fail to substitute something > silently _without_ causing the package build to fail with errors, are > dangerous. In this case, however, on 64-bit multiarch targets the files would > be installed into /lib and not found by %{_lib} in the %files section. A > failing sed would lead to rpmbuild errors. That's okay. No, build package will be filed later in %files section when file not found in %{_lib} will be raised. This is why it hack appeared. > > I think external package give more flexibility to user in any case. > > So? What flexibility would that be? First of all, it requires the -devel > package. Second, the -devel package requires the main package. Yes, off course. I expect what all my dependencies is correct and installation of ne7ssh-examples would require ne7ssh and ne7ssh-devel and all other required dependencies. BUT, you are free ot do not install ne7ssh-example - it is not required by anything other. > Third, the > included Makefile explicitly links with libbotan, so a dependency on > botan-devel is missing => ne7ssh-devel is missing "Requires: botan-devel" as > its headers include botan headers. Why? BuildRequires: cmake botan-devel present in spec. > Fourth, one cannot install the -example > package like a separate -doc package to peruse the source code. Yes, I known. This is because it contain Makefile to build examples, and its will fail, if ne7ssh-devel is not present in system. So, it is ok. If you only want read examples and known what you do, you always can install it forced without dependencies. > Fifth, the > examples are stored in their own directory instead of together with the API > documentation. And what? This is incorrect? > Sixth, the examples are just 25K uncompressed. And what? It can't be separate package because it? > Seventh, the base > ne7ssh package contains 1.7M of API %doc files. Better split those files into a > -doc package. Yes, there you are right. I'll do that. > It's covered by the guidelines even. Please, can you point me where? > The package %description doesn't explain what the package contains. A first > sentence like the %summary is missing. Don't assume that %summary and > %description are displayed above eachother. Should I repeat Summary in %description?? I believe not. > There is typo in the %description: s/it's/its/ Thank you, fixed. P.S. I'll -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review