Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524545 --- Comment #2 from Shakthi Kannan <shakthimaan@xxxxxxxxx> 2009-09-23 14:15:43 EDT --- ==> Thanks for your feedback. - The versioned shared libraries should not be in the devel package as they are required by the snacc binary itself. (The *.so symlinks, however, should remain in the devel package). ==> DONE. - The *.ans1 files are also required by snacc and so should be moved out of the devel package. ==> DONE. Moved to -base package. - Some of the documentation (*.tex and *.bib) refers to the c-lib and c++-lib APIs (these should go in snacc-devel) and some refer to the use of various binaries in the snacc package (these should go in snacc). ==> Since all *.tex files are incleded with snacc.tex file, I have retained it in -devel package. The -base package has the .ps file for snacc user manual. - The C/C++ examples should go in devel package (they aren't being packaged at the moment). ==> DONE. - The C/C++ header files for the c-lib and c++-lib should go into the devel package. ==> They were already in -devel package. They were in /usr/include/snacc/. Now, I have explicitly mentioned them. - There's a spelling mistake in the description (s/dample/sample/). ==> FIXED. Another idea might be to create libsnacc and libsnacc-devel packages for the c and c++ libraries and put just the binaries in snacc. In fact, I think this would be the optimal solution. ==> DONE. SPEC: http://shakthimaan.fedorapeople.org/SPECS/snacc.spec SRPM: http://shakthimaan.fedorapeople.org/SRPMS/snacc-1.3-2.fc11.src.rpm Successful Koji builds for F-10, F-11 and EL-5 respectively: http://koji.fedoraproject.org/koji/taskinfo?taskID=1701352 http://koji.fedoraproject.org/koji/taskinfo?taskID=1701418 http://koji.fedoraproject.org/koji/taskinfo?taskID=1701457 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review