Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524423 Ionuț Arțăriși <mapleoin@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mapleoin@xxxxxxxxxxxxxxxxx --- Comment #2 from Ionuț Arțăriși <mapleoin@xxxxxxxxxxxxxxxxx> 2009-09-23 07:30:21 EDT --- Hello, I'm not in the packager group yet and so I cannot approve your package. Nor can I be your sponsor. I'm just trying to review. Here are my suggestions: the %{?_smp_mflags} is useless as the makefile doesn't interpret it The string.h patch should probably go upstream. Here are some other issues from the Review Guidelines that I've found applicable: # MUST: rpmlint must be run on every package. The output should be posted in the review.[1] ciso-debuginfo.i586: E: debuginfo-without-sources 3 packages and 0 specfiles checked; 1 errors, 0 warnings. # MUST: The spec file must be written in American English. [5] Some typos: Patch instead of Pach and the description might sound better like this: A small tool to compress/decompress ISO to/from CSO (Compressed ISO for PSP) # MUST: Header files must be in a -devel package. [20] Also: I could transform an iso to cso and back again, but I don't know how to test that the CSO isn't corrupted. Good luck! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review