[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=465636





--- Comment #9 from Stefan Schulze Frielinghaus <stefan@xxxxxxxxxxxx>  2009-09-20 07:11:28 EDT ---
(In reply to comment #8)
> I see you have acquired sponsoree status just five days ago, and you clearly
> have not understood yet completely how the package review process works.

Quite right. The Fedora bureaucracy is still new to me. But hey weren't we all
once small? Calm down big boy.

> You really should go through the review checklist in the review bug (here).
> It's not just for me or you, it's also for other people who look at the
> reviews. A simple "Looks OK" is sloppy reviewing, since it's very likely you
> have forgot to check something. And it doesn't tell other people that you have
> really went through everything.

Like I already said in comment #5. I went through _all_ must (and should) items
of https://fedoraproject.org/wiki/Packaging/ReviewGuidelines. And I did all
steps of https://fedoraproject.org/wiki/Package_Review_Process which does not
state that a comment like "APPROVED" should be written.

> Learn to walk before you run, OK? :)

Learning by doing. A wise man said this once before :)

> PS. Setting fedora-review to + is not enough, since anyone can remove or write
> over the flag. When you a package passes the review, write APPROVED in the
> comment field.  

At least this one is a constructive comment.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]