Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225657 Till Maas <opensource@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |opensource@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |opensource@xxxxxxxxx Flag| |fedora-review? --- Comment #5 from Till Maas <opensource@xxxxxxxxx> 2009-09-16 19:54:32 EDT --- - The patches need comments wrt their upstream status: https://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment - You need to either use $RPM_BUILD_ROOT/$RPM_OPT_FLAGS or %{buildroot}/%{optflags}, but currently both styles are used: https://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS I'll try to perform a full review soon. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review