Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475852 --- Comment #33 from Jochen Schmitt <jochen@xxxxxxxxxxxxxxx> 2009-09-16 12:40:52 EDT --- (In reply to comment #30) > FIX rpmlint > gnustep-base.src: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line > You can fix this with Emacs' "untabify" command Done. > FIX license field accurate > some files are actually GPLv3+, while others are still GPLv2+. This means > the aggregate is GPLv3+. Most LGPL files are v2+ but some (makefiles! should > these not be GNU public domain ?!) are LGPLv3+. Assuming that upstream > intention is to switch files to (L)GPLv3+ as they are updated, I think we > can say "LGPLv3+ and GPLv3+". If you could email upstream and get a > clarification, and put a comment with the URL to the upstream mail from a > mailing list archive, that would be great. > > The other alternative is to split out the v2 and v3 files, but that would be > crazy if the division is merely temporal, rather than functional (i.e. if > there is no distinct subpackage with a different license) You should not aggregate several Licenses to one which may compatible to the all of the others. > FIX spec legible > - the comment for renaming pl mentions pllit but the file is renamed to > pllist. Done. typo. > FIX build dependencies complete > gmp-devel listed twice > /usr/bin/iconv is bad for two reasons: > - we frown on file-based dependencies because they can be expensive to Done. > FIX own all directories > gnustep-base-devel should additionally requires gnustep-make: > - it is a development package, and is useless without the other makefiles > - it installs into %{_libdir}/GNUstep/Makefiles/Additional which is owned > by gnustep-make Done. > FIX require package not files > see above (iconv) Done. Next Release: Spec URL: http://www.herr-schmitt.de/put/gnustep-base/gnustep-base.spec SRPM URL: http://www.herr-schmitt.de/put/gnustep-base/gnustep-base-1.18.0-5.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review