Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518017 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |fedora@xxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> 2009-09-06 01:47:46 EDT --- All seems ok in the spec. Just a quick note Froms upstream, it requires PHP 5.1.3 (which is still not available in EPEL4), so, for documentation: BuildRequires: php-devel >= 5.1.3 A minimal %check seems usefull (even if not mandatory), for example : %check # simple module load test cd %{pecl_name}-%{version} php --no-php-ini \ --define extension_dir=modules \ --define extension=%{pecl_name}.so \ --modules | grep %{pecl_name} I will do a full review asap. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review