Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518949 Kevin Fenzi <kevin@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kevin@xxxxxxxxx --- Comment #5 from Kevin Fenzi <kevin@xxxxxxxxx> 2009-09-06 00:28:39 EDT --- Hey Matt. I took a quick look, and a few things to address before a review: 1. It looks like your are building some of the internally bundled copies of libraries: Build tkhtml3 ........................: yes Build tkImg ..........................: yes Build Utah Raster Toolkit.............: yes Build Template Numerical Toolkit......: yes Build openNURBS.......................: yes Build NIST STEP Class Libraries.......: yes You should use system versions of these, or in cases they don't yet exist in Fedora, submit them for review first. I know tkImg at least is in Fedora already, not sure about the others. 2. The License tag doesn't appear right... see the Licesing page for the correct tags, and note that "," is not valid. 3. rpmlint has a number of complaints. Try and address those? If you can take a look at those and spin up a new package I can look at reviewing this for you. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review