Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pecl-Fileinfo - libmagic bindings https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206398 ------- Additional Comments From fedora@xxxxxxxxxxxxxxxx 2006-09-18 02:27 EST ------- Spec URL: http://theholbrooks.org/RPMS/php-pecl-Fileinfo.spec SRPM URL: http://theholbrooks.org/RPMS/php-pecl-Fileinfo-1.0.3-2.src.rpm Jason, I've made the changes you requested. Remi, I based this spec file off of you pecl-zip spec :), which I see has now been updated to reflect the changes you suggest. I agree extracting package.xml into the build directory is a very bad idea, and a good catch on your part BTW. I've made the same changes to this package, but I'm not thrilled about having to add 'Fileinfo-%{version}/' in front of my %doc files so RPM could find them. For pecl packages with more files, that gets even worse. For the moment, however, I can't think of any other way to do it. +1 for adding it to the guidelines (at least as a suggestion for now, if not a requirement). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review