Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pecl-Fileinfo - libmagic bindings https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206398 Fedora@xxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Fedora@xxxxxxxxxxxxxxxxx ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-09-15 21:23 EST ------- A couple of rpmlint complaints: W: php-pecl-Fileinfo summary-not-capitalized libmagic extension Indeed, the summary should be capitalized. But it would also be good to flesh the summary out a bit. E: php-pecl-Fileinfo zero-length /usr/share/doc/php-pecl-Fileinfo-1.0.3/EXPERIMENTAL In general you shouldn't package zero length files. Also, the %description could use a bit of grammatical cleanup. I suggest: ----- This extension allows the retrieval of file type information for the vast majority of files. This information may includes such information as dimensions or compression quality of images, duration of sound files, etc. Additionally, it can also be used to retrieve the MIME type for a particular file and, for text files, the proper language encoding. ----- You must use Requires: php-api = %{php_apiver}, not >=. If the PHP API version changes, you will need to recompile this module. Review: * source files match upstream: 799930038f76af23e391eef45789c607 Fileinfo-1.0.3.tgz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * debuginfo package looks complete. X rpmlint is silent. X final provides and requires are sane: config(php-pecl-Fileinfo) = 1.0.3-1.fc6 fileinfo.so()(64bit) php-Fileinfo = 1.0.3-1.fc6 php-pecl(Fileinfo) = 1.0.3-1.fc6 php-pecl-Fileinfo = 1.0.3-1.fc6 = config(php-pecl-Fileinfo) = 1.0.3-1.fc6 libmagic.so.1()(64bit) X php-api >= 20041225 * %check is not present; not test suite upstream. * no shared libraries are added to the regular linker search paths. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. ------- Additional Comments From Fedora@xxxxxxxxxxxxxxxxx 2006-09-17 10:52 EST ------- One comment : %setup -q -n Fileinfo-%{version} Is not safe because package.xml will be store in BUILD directory (can be overide by another build running at the same time). %setup -c -q cd Fileinfo-%{version} Seem safer This should probably be add to the PHP Guidelines (for PEAR and PECL) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review