Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=519538 --- Comment #5 from Michel Alexandre Salim <michael.silvanus@xxxxxxxxx> 2009-08-31 17:17:01 EDT --- Almost ready to pass review; there is a trivial summary change to make, and a more serious case of some dependencies not being listed Koji build (F-12): http://koji.fedoraproject.org/koji/taskinfo?taskID=1646731 MUST • rpmlint: source -- clean clutter-sharp.x86_64: E: no-binary clutter-sharp.x86_64: W: only-non-binary-in-usr-lib These are harmless, rpmlint is not Mono-aware clutter-sharp-devel.x86_64: W: summary-not-capitalized pkgconfig file for clutter-sharp clutter-sharp-devel.x86_64: W: no-documentation The first should probably be fixed. The default spec file has Development files for %{name} which could be used. Esp. since we're packaging more than just the .pc file! OK package name OK spec file name OK package guideline-compliant OK license complies with guidelines OK license field accurate OK license file not deleted OK spec in US English OK spec legible OK source matches upstream OK builds under >= 1 archs, others excluded (Koji) OK build dependencies complete (Koji) FAIL on the other hand, runtime dependencies are not complete rpm -q --requires clutter-sharp rpm -e clutter 2>out.txt cat out.txt | grep sharp shows that the dependency on clutter is not picked up; this should be added manually. Also, once clutter-gtk can be enabled (prod the maintainer for an update?) you'd want to Requires: clutter-gtk, and meanwhile, now you want to %exclude %{_libdir}/pkgconfig/clutter-gtk-sharp.pc NA locales handled using %find_lang, no %{_datadir}/locale NA library -> ldconfig NA relocatable: give reason OK own all directories OK no dupes in %files OK permission OK %clean RPM_BUILD_ROOT OK macros used consistently OK Package contains code OK headers in -devel OK if contains *.pc, req pkgconfig OK devel requires versioned base package OK clean buildroot before install OK filenames UTF-8 SHOULD OK package build in mock on all architectures ? package functioned as described not tested OK scriplets are sane OK require package not files -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review