Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=519538 --- Comment #4 from Christian Krause <chkr@xxxxxxxxxxx> 2009-08-28 10:32:28 EDT --- (In reply to comment #3) > Thanks for creating the package. I don't have the time to make a full review > but I noticed some things. > > * mixed use of %{buildroot} and $RPM_BUILD_ROOT ($RPM_BUILD_ROOT only in > %install) > * latest changelog version is 0-0.3 but release field says 0.2 > * shouldn't the %defattr filed be %defattr(-,root,root,-)? Thanks for the comment - all issues fixed: Spec URL: http://chkr.fedorapeople.org/review/clutter-sharp.spec SRPM URL: http://chkr.fedorapeople.org/review/clutter-sharp-0-0.3.20090828.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review