Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=167525 --- Comment #9 from D Haley <mycae@xxxxxxxxx> 2009-08-28 08:59:03 EDT --- SPEC URL: http://dhd.selfip.com/427e/cpptasks-1.0b5-2.spec SRPM URL: http://dhd.selfip.com/427e/cpptasks-1.0b5-2.fc10.src.rpm RPMLint: $ cat tmp Wrote: /home/makerpm/rpmbuild/SRPMS/cpptasks-1.0b5-2.fc10.src.rpm Wrote: /home/makerpm/rpmbuild/RPMS/noarch/cpptasks-1.0b5-2.fc10.noarch.rpm Wrote: /home/makerpm/rpmbuild/RPMS/noarch/cpptasks-javadoc-1.0b5-2.fc10.noarch.rpm $ rpmlint -v `cat tmp | awk '{print $2}'` cpptasks.src: I: checking cpptasks.noarch: I: checking cpptasks.noarch: W: non-conffile-in-etc /etc/ant.d/cpptasks cpptasks-javadoc.noarch: I: checking 3 packages and 0 specfiles checked; 0 errors, 1 warnings. I'm ignoring the warning, as I don't think this should be marked as a configuration file. Users should *not* be modifying this file in any way. Koji: F10:http://koji.fedoraproject.org/koji/taskinfo?taskID=1640839 F11:http://koji.fedoraproject.org/koji/taskinfo?taskID=1640849 >I would have found this sooner if it wasn't marked CLOSED NOTABUG and blocked >FE-DEADREVIEW. :-) Mea culpa. >In the absence of a manual, how about putting a URL to the online manual in the >description or in a README.fedora? Good idea. Done. > Does this package need to wait for that release of maven in order to build the manual? Well, I don't know. It needs the clirr plugins, so it isn't going to build at the moment. I must admit I find maven somewhat opaque, and am not overly keen on packaging clirr. If it gets packaged, I will update however. >Is there a reason for not building with gcj? Sorry, not sure why this needs to be done. If licencing is the concern, Sun's javac has been free (as in software) for quite a while now, I believe since F9. I note that packages such as maven2-plugin-release use OpenJDK in preference to gcj... > Does this package need to drop a file into /etc/ant.d? Yes, Fixed. I also moved the jar file + symlink to %{_javadir}/ant/, in line with other ant tasks (ant-commons-logging,ant-junit, etc) >The -javadoc subpackage does not require the base package. Fixed. >Please replace the %doc lines for the base package with this: Fixed, however I also added README.fedora as well. Thanks for the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review