Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=506425 Gareth John <gareth.l.john@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gareth.l.john@xxxxxxxxxxxxx | |m --- Comment #3 from Gareth John <gareth.l.john@xxxxxxxxxxxxxx> 2009-08-25 19:44:16 EDT --- Hi Aleksey, First off your link is broken but I found http://aleksey2005.fedorapeople.org/lightsquid-1.8-1.fc11.src.rpm so that is what I'm going on as it's a later version RPMLINT OUTPUT: $ rpmlint lightsquid.spec lightsquid.spec:84: E: files-attr-not-set lightsquid.spec:85: E: files-attr-not-set lightsquid.spec:86: E: files-attr-not-set lightsquid.spec:87: E: files-attr-not-set lightsquid.spec:88: E: files-attr-not-set lightsquid.spec:89: E: files-attr-not-set lightsquid.spec:90: E: files-attr-not-set lightsquid.spec:91: E: files-attr-not-set lightsquid.spec:93: E: files-attr-not-set ---Needs "%defattr(-,root,root,-)" under Files section lightsquid.spec: E: no-cleaning-of-buildroot %install --- Again easily sorted with "rm -rf $RPM_BUILD_ROOT" at start of install section lightsquid.spec: W: no-%build-section --- I'm stumped at the minute 0 packages and 1 specfiles checked; 10 errors, 1 warnings. $ rpmlint ../SRPMS/lightsquid-1.8-1.fc11.src.rpm lightsquid.src:84: E: files-attr-not-set lightsquid.src:85: E: files-attr-not-set lightsquid.src:86: E: files-attr-not-set lightsquid.src:87: E: files-attr-not-set lightsquid.src:88: E: files-attr-not-set lightsquid.src:89: E: files-attr-not-set lightsquid.src:90: E: files-attr-not-set lightsquid.src:91: E: files-attr-not-set lightsquid.src:93: E: files-attr-not-set lightsquid.src: E: no-cleaning-of-buildroot %install lightsquid.src: W: no-%build-section 1 packages and 0 specfiles checked; 10 errors, 1 warnings. --------------------------------------------------- $ rpmlint ../RPMS/noarch/lightsquid-* lightsquid.noarch: E: script-without-shebang /usr/share/lightsquid/tools/fixreport.pl ---May want to talk about this to upstream I'm not sure if you know of a reason why this script is missing a shebang lightsquid-apache.noarch: W: no-documentation ---I'm new to this game so not sure what initiative to take I know this error was ok for a package I did I assume its the same in this case 2 packages and 0 specfiles checked; 1 errors, 1 warnings. Also "All patches should have an upstream bug link or comment" again maybe talk to upstream. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review