Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517720 Stepan Kasal <skasal@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #1 from Stepan Kasal <skasal@xxxxxxxxxx> 2009-08-25 08:38:58 EDT --- Review: + package builds in koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1631969 FAIL rpmlint is silent for SRPM and for RPM. - summary ends with dot; please delete it - OTOH, the %description sentence should end with a dot + source file matches upstream url + package meets naming and packaging guidelines + specfile is properly named, is cleanly written + Spec file is written in American English + Spec file is legible + dist tag is present + build root is correct + license is open source-compatible FAIL License text is included in package - please add LICENSE to %doc + %doc is present. FAIL BuildRequires are proper - please add perl(HTTP::Cookies) + %clean is present + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does own the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test succeeded + provides and requires OK + Not a GUI application A suggestion: in %files, you might replace %{perl_vendorlib}/* by the more specific %{perl_vendorlib}/BZ Please make the four small changes under the three FAILs above and consider my suggestion. With these nits fixed, the package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review