Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=510743 --- Comment #15 from Andreas Schwab <schwab@xxxxxxxxxx> 2009-08-25 08:53:17 EDT --- Spec URL: http://home.mnet-online.de/whitebox/aranym.spec SRPM URL: http://home.mnet-online.de/whitebox/aranym-0.9.8-0.3.beta.fc11.src.rpm Thank you for the detailed review. A few notes on your notes: 5. That's really a bug in zlib. 6. I've used requires(hint) instead. 9. That makes debugging of build problems harder, and can make the debuginfo package incomplete. rpmlint should really be fixed, and configuring in a subdir should be supported by default. IMHO srcdir != builddir should be the norm. The included spec file uses --disable-nat-debug as well. 10. That wouldn't change anything since the installation won't preserve timestamps anyway. And I've already fixed it upstream. 11. Fixed upstream. 15. The things in /usr/share/aranym are part of the emulation. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review